Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(REST API): add url to (un)archive cards #6138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xyjonas
Copy link

@xyjonas xyjonas commented Jul 25, 2024

Summary

I implemented two new routes /api/v{apiVersion}/boards/{boardId}/stacks/{stackId}/cards/{cardId}/archive & /api/v{apiVersion}/boards/{boardId}/stacks/{stackId}/cards/{cardId}/unarchive, that will archive/unarchive cards via cardService. Documentation and unit tests are also included.
Please review my work and let me know what you think.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

Copy link
Contributor

github-actions bot commented Aug 9, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request and sorry for taking so long to review. Generally this seems good to me. However since this is a new endpoint we need to bump the API version so that clients can detect if the new API endpoint is actually available in https://github.com/nextcloud/deck/blob/fix/nextcloud-30-design-issues/lib/Capabilities.php#L39

Signed-off-by: Jonas H. Steiner <jsteiner@plusline.net>
@juliusknorr juliusknorr force-pushed the programmatic-archive-unarchive-card branch from a0cdf87 to e986ca3 Compare August 29, 2024 10:33
@luka-nextcloud
Copy link
Contributor

@juliushaertl The PR looks good to me, can we merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

(Un)Archive cards programmatically via REST API
3 participants