Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cards): add card cloning ability #6452

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(cards): add card cloning ability #6452

wants to merge 7 commits into from

Conversation

grnd-alt
Copy link
Member

@grnd-alt grnd-alt commented Oct 29, 2024 •
edited
Loading

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@grnd-alt grnd-alt linked an issue Oct 29, 2024 that may be closed by this pull request
Clone/copy a card #1813
Open
@grnd-alt grnd-alt force-pushed the feat/1813-clonecopy-a-card branch from 950429a to 4212c10 Compare November 4, 2024 11:58
@grnd-alt grnd-alt requested a review from juliusknorr November 7, 2024 09:51
@luka-nextcloud
Copy link
Contributor

@grnd-alt Missing unit test for function CardService->cloneCard()
Missing unit test for function LabelService->cloneLabelIfNotExists()
I think cypress tests should be added as well.

luka-nextcloud
luka-nextcloud requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@luka-nextcloud luka-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review tests. Otherwise it looks good!

@grnd-alt
feat(cards): add card cloning ability
659baad 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
fix(cards): use copy-content icon for cloning cards
2fd66a9 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
introduce cloneCard backendFunctionality
36744fc 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
check user-permsisions when assigning to cloned card
8bf310b 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt
feat(tests): add tests for labelService and cardService functions
d5c2621 
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
@grnd-alt grnd-alt force-pushed the feat/1813-clonecopy-a-card branch from 3045c71 to d5c2621 Compare November 14, 2024 09:49
@hectorandac
Copy link

This is awesome! I'm eagerly waiting for this feature 🎉

@grnd-alt grnd-alt requested a review from elzody as a code owner November 25, 2024 12:56
@grnd-alt
add cypress tests for cardfeatures
cbb13e2 
Signed-off-by: grnd-alt <git@belakkaf.net>
@grnd-alt grnd-alt force-pushed the feat/1813-clonecopy-a-card branch from cdc07d8 to cbb13e2 Compare November 25, 2024 13:03
@grnd-alt
skip cypress test causing chrome out of memory crash
ed2f7b5 
Signed-off-by: grnd-alt <git@belakkaf.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud requested changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@elzody elzody Awaiting requested review from elzody elzody is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clone/copy a card
4 participants
@grnd-alt @luka-nextcloud @hectorandac @juliusknorr