Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public board share (WIP) #654

Closed
wants to merge 2 commits into from
Closed

Public board share (WIP) #654

wants to merge 2 commits into from

Conversation

NebriBlackwing
Copy link
Member

  • Resolves: #
  • Target version: master

Summary

Closes Issue #14 when completed.

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@juliushaertl got a great start on the interface + backend logic. I'm trying to verify that I have data flowing from the database to the interface now. I've coded in the logic that I believe is necessary on the php side, but I'm struggling to see how it gets from the PHP backend into the BoardController.js. Are you able to give me a quick rundown of that flow? I'm quite sure I've missed something that is preventing my publicShares from making it into the final object that the boardservice.getCurrent() function gets at the end of the call. Yes, I did add some records into my database table to ensure there is something there to pull out :).

Ryan Fletcher added 2 commits October 16, 2018 12:43
…n calls.

Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
Signed-off-by: Ryan Fletcher <ryan.fletcher@codepassion.ca>
@juliusknorr
Copy link
Member

got a great start on the interface + backend logic. I'm trying to verify that I have data flowing from the database to the interface now. I've coded in the logic that I believe is necessary on the php side, but I'm struggling to see how it gets from the PHP backend into the BoardController.js. Are you able to give me a quick rundown of that flow? I'm quite sure I've missed something that is preventing my publicShares from making it into the final object that the boardservice.getCurrent() function gets at the end of the call. Yes, I did add some records into my database table to ensure there is something there to pull out :).

We need a new PHP controller method for the public endpoint. This one will render the basic HTML and load the javascript code. After that we need to adjust the whole angular app a bit, maybe we have flag we set in the angular app element that it should load the public view. Then we can just grab the token from the url and fetch only the single public board.

@Nebri Depending on the motivation you bring, maybe we could take this as a first step of our vue.js migration #355 and start building components for deck with the public pages. So we have an independent playground for vue to start with and can later on migrate more and more parts of the deck app with those already existing components. I'd of course also be up to help you with the vue bootstrapping in the deck repo. What do you think about that?

@NebriBlackwing
Copy link
Member Author

@juliushaertl Not a bad place to start actually, I'll need to take some time to explore and teach myself vue before hand.

On a side note since I'm still having trouble finding work, I've decided that it's best for me to spend more time on my job search tactics. I'm going to unassign myself from this task for now and revisit this in the new year if it's still open.

@juliusknorr
Copy link
Member

On a side note since I'm still having trouble finding work, I've decided that it's best for me to spend more time on my job search tactics. I'm going to unassign myself from this task for now and revisit this in the new year if it's still open.

Sure, take your time there. 😉 I wish you all the best on your job search.

@juliusknorr
Copy link
Member

@RyanFletcher86 We are starting to migrate Deck to Vue.js so I'm closing this for now, since it is based on the existing angular code. Anyone wanting contribute, feel free to open a new pull request against the vue branch.

@juliusknorr juliusknorr closed this Dec 6, 2018
@juliusknorr juliusknorr deleted the public-board-share branch February 14, 2019 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants