address review comments

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
nextcloud · Jul 5, 2021 · adaa594 · adaa594
1 parent b02c96d
commit adaa594
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/libsync/vfs/cfapi/cfapiwrapper.cpp b/src/libsync/vfs/cfapi/cfapiwrapper.cpp
@@ -204,7 +204,6 @@ void CALLBACK cfApiFetchDataCallback(const CF_CALLBACK_INFO *callbackInfo, const
     QObject::connect(vfs, &OCC::VfsCfApi::hydrationRequestFinished, &loop, [&](const QString &id) {
         qDebug(lcCfApiWrapper) << "Hydration finished for request" << id;
         if (requestId == id) {
-            signalSocket.close();
             loop.quit();
         }
     });

diff --git a/src/libsync/vfs/cfapi/hydrationjob.cpp b/src/libsync/vfs/cfapi/hydrationjob.cpp
@@ -147,6 +147,8 @@ void OCC::HydrationJob::cancel()
     }
 
     _signalSocket->write("cancelled");
+    _signalSocket->close();
+    _transferDataSocket->close();
 
     emitFinished(Cancelled);
 }