fix test and code to not stop on case clash errors

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
nextcloud · Nov 30, 2022 · af49e10 · af49e10
1 parent b687548
commit af49e10
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/libsync/propagatorjobs.cpp b/src/libsync/propagatorjobs.cpp
@@ -178,7 +178,7 @@ void PropagateLocalMkdir::startLocalMkdir()
 
     if (Utility::fsCasePreserving() && propagator()->localFileNameClash(_item->_file)) {
         qCWarning(lcPropagateLocalMkdir) << "New folder to create locally already exists with different case:" << _item->_file;
-        done(SyncFileItem::NormalError, tr("Attention, possible case sensitivity clash with %1").arg(newDirStr));
+        done(SyncFileItem::FileNameClash, tr("Attention, possible case sensitivity clash with %1").arg(newDirStr));
         return;
     }
     emit propagator()->touchedFile(newDirStr);

diff --git a/test/testsyncengine.cpp b/test/testsyncengine.cpp
@@ -1287,20 +1287,20 @@ private slots:
     {
         FakeFolder fakeFolder{ FileInfo{} };
         fakeFolder.remoteModifier().mkdir("A");
+        fakeFolder.remoteModifier().mkdir("toDelete");
         fakeFolder.remoteModifier().insert("A/file");
 
         QVERIFY(fakeFolder.syncOnce());
         QCOMPARE(fakeFolder.currentLocalState(), fakeFolder.currentRemoteState());
 
         fakeFolder.remoteModifier().insert("A/FILE");
-        QVERIFY(!fakeFolder.syncOnce());
+        QVERIFY(fakeFolder.syncOnce());
 
-        fakeFolder.remoteModifier().mkdir("B");
-        fakeFolder.remoteModifier().rename("A/file", "B/file");
-        fakeFolder.remoteModifier().remove("A");
+        fakeFolder.remoteModifier().mkdir("a");
+        fakeFolder.remoteModifier().remove("toDelete");
 
-        QVERIFY(!fakeFolder.syncOnce());
-        auto folderA = fakeFolder.currentLocalState().find("A");
+        QVERIFY(fakeFolder.syncOnce());
+        auto folderA = fakeFolder.currentLocalState().find("toDelete");
         QCOMPARE(folderA, nullptr);
     }
 };