Fix memory leak.

Signed-off-by: alex-z <blackslayer4@gmail.com>
nextcloud · Mar 2, 2023 · e3f5147 · e3f5147
1 parent 501801b
commit e3f5147
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/libsync/updatefiledropmetadata.cpp b/src/libsync/updatefiledropmetadata.cpp
@@ -122,13 +122,13 @@ void UpdateFileDropMetadataJob::slotFolderEncryptedMetadataReceived(const QJsonD
     qCDebug(lcUpdateFileDropMetadataJob) << "Metadata Received, Preparing it for the new file." << json.toVariant();
 
     // Encrypt File!
-    _metadata = new FolderMetadata(propagator()->account(), json.toJson(QJsonDocument::Compact), statusCode);
+    _metadata.reset(new FolderMetadata(propagator()->account(), json.toJson(QJsonDocument::Compact), statusCode));
     if (!_metadata->moveFileDropToFiles()) {
         unlockFolder();
         return;
     }
 
-    emit fileDropMetadataParsedAndAdjusted(_metadata);
+    emit fileDropMetadataParsedAndAdjusted(_metadata.data());
 
     const auto updateMetadataJob = new UpdateMetadataApiJob(propagator()->account(), _folderId, _metadata->encryptedMetadata(), _folderToken);
     connect(updateMetadataJob, &UpdateMetadataApiJob::success, this, &UpdateFileDropMetadataJob::slotUpdateMetadataSuccess);

diff --git a/src/libsync/updatefiledropmetadata.h b/src/libsync/updatefiledropmetadata.h
@@ -16,6 +16,8 @@
 
 #include "owncloudpropagator.h"
 
+#include <QScopedPointer>
+
 class QNetworkReply;
 
 namespace OCC {
@@ -61,7 +63,7 @@ private slots:
     QByteArray _folderToken;
     QByteArray _folderId;
 
-    FolderMetadata *_metadata = nullptr;
+    QScopedPointer<FolderMetadata> _metadata;
 };
 
 }