Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files with ":" ignored but synchronization shows as successful (no error message) #1723

Closed
Xansala opened this issue Jan 13, 2020 · 7 comments

Comments

@Xansala
Copy link
Contributor

Xansala commented Jan 13, 2020

Expected behaviour

Syncing pictures from my iPhone (iOS 13, Nextcloud 2.25.3.6) to my VPS (Ubuntu 16.04, Nextcloud 15.0.12) and then back to my desktop (Windows 10 x64, Nextcloud 2.6.2). iPhone stored pictures with time and ":" in the name which is no problem for Linux but files are not synced to Windows. Due to this issue, an error message is shown. (maybe apart from the file handling as indicated #1537 )

Actual behaviour

Files with ":" in the name are ignored, synchronization is shown as successful.

Steps to reproduce

  1. Create a file containing ":" in the linux server
  2. Try to sync with Windows Client for Nextcloud

Client configuration

Client version: 2.6.2

Operating system: Windows 10 x64, 1909

OS language: English

Installation path of client: C:\Program Files\Nextcloud

Server configuration

Nextcloud version: 15.0.12

Logs

[OCC::PropagateItemJob::scheduleSelfOrChild Starting INSTRUCTION_IGNORE propagation of "Video12,Dec 29 2019, 13:01:32:23,PM 4528.mov" by OCC::PropagateIgnoreJob(0x24b6b0abd50)
[OCC::PropagateItemJob::done Could not complete propagation of "Video12,Dec 29 2019, 13:01:32:23,PM 4528.mov" by OCC::PropagateIgnoreJob(0x24b6b0abd50) with status 6 and error: "File names containing the character ':' are not supported on this file system."
[OCC::ActivityWidget::slotItemCompleted Item "Video12,Dec 29 2019, 13:01:32:23,PM 4528.mov" retrieved resulted in "File names containing the character ':' are not supported on this file system."
[OCC::ActivityWidget::slotItemCompleted Item "Video12,Dec 29 2019, 13:01:32:23,PM 4528.mov" retrieved resulted in error "File names containing the character ':' are not supported on this file system."

[OCC::Folder::slotSyncFinished Client version 2.6.2stable-Win64 (build 20191224) Qt 5.12.5 SSL OpenSSL 1.1.1d 10 Sep 2019
[OCC::Folder::slotSyncFinished SyncEngine finished without problem.
[OCC::Folder::showSyncResultPopup Folder sync result: 3

@cloo
Copy link

cloo commented Mar 4, 2020

I confirm the case with "|" character.

Naturally Windows does not support such filenames, but users should be informed that something is not syncing.

(I risked getting into fight with a coworker, because the sync was obviously working, and I didnt see his files appearing on time)

Nextcloud 16, Windows client 2.6.2

@claell
Copy link

claell commented Apr 4, 2020

This seems to be a duplicate of #464. Please confirm and close this issue if that is the case. Discussion can continued in the original issue then.

@Xansala
Copy link
Contributor Author

Xansala commented Apr 11, 2020

@claell this is not the same issue. #464 is in general about the issue with some characters in Windows, while this issue mentions that the error with special characters for syncing is not popping up (more an error reporting topic).

Maybe to specify: although the synchronization was not complete due to the files that could not be synced, the log shows "[OCC::Folder::slotSyncFinished SyncEngine finished without problem.".

@claell
Copy link

claell commented Apr 11, 2020

Alright, thanks for pointing that out. I will leave this open then, since it addresses a more specific issue (probably also resulting of the causes #464 describes) but might be solvable with a different solution.

@camilasan camilasan self-assigned this May 3, 2020
@damienvancouver
Copy link

I just fixed this after an employee renamed files in the web UX to have "|" chars in them.

I can confirm that it is a silent failure:

  • No errors in the client (the folders just vanish)
  • No log entries whatsoever of the problem folders/files in the sync log.

That behavior is dangerous because it erodes the trust/credibility that the users have in Nextcloud: it needs to feel safe / rock solid / ephemeral etc. in order for mass adoption to take place.

Ideally there would be both log message and error message.

The solution of "rename the file in the web interface" is a good one to offer as well.

@er-vin
Copy link
Member

er-vin commented Aug 11, 2020

Duplicate of #464

@er-vin er-vin marked this as a duplicate of #464 Aug 11, 2020
@er-vin er-vin closed this as completed Aug 11, 2020
@Xansala
Copy link
Contributor Author

Xansala commented Aug 18, 2020

Duplicate of #464

@er-vin
This is not a duplication. Although the issue with special characters in Windows is the same, this issue refers to how the client is reporting the issue. If you have a file with special charter in your linux server with Nextcloud, then this file is not synchronized to your Windows client but the Nextcloud client is still reporting the synchronization as successful without any indication of such character issue (apart from the log file where "normal" users would not look into).

It is fine to merge it to #464, but please adjust the description of this issue accordingly as this one references a potential renaming of special characters but dues not tackle the issue in the sync client reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants