Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folders called with double quotes are not syncing in windowsclients #2222

Closed
chillriver opened this issue Jul 21, 2020 · 9 comments
Closed
Labels
enhancement enhancement of a already implemented feature/code good first issue

Comments

@chillriver
Copy link

Expected behaviour

The windows client should syncing folders with double quotes

Actual behaviour

Folders called with double quotes are not syncing in windows clients, but Linux client can do

Steps to reproduce

  1. Online in Nextcloud create folder with double quotes
  2. Syncing with desktop-client on windows
  3. No folders are showing

Client version: Client 2.6.5
Operating system: Windows 10
Nextcloud version: 18.0.7

@Escubaer
Copy link

double quote is a forbidden character in Windows, what do you expect?
https://stackoverflow.com/questions/1976007/what-characters-are-forbidden-in-windows-and-linux-directory-names

@chillriver
Copy link
Author

Thanks for that information and this make sense, but maybe it should be intercepted, because some users don't know this issue by create folders online. They are surprised of lost folders.

@er-vin er-vin added enhancement enhancement of a already implemented feature/code good first issue labels Jul 21, 2020
@er-vin
Copy link
Member

er-vin commented Jul 21, 2020

I guess it's captured in the logs, maybe a warning could be shown, might be something for the activity list in upcoming 2.7. If someone is willing to cook a patch for it I can help review.

@sberegszaszi
Copy link

Hi,
@chillriver Just asking to clarify, what do you mean by "folders called with double quotes". Do you mean, that they have double quotes in the name, like [This"folder"] for example?

@sberegszaszi
Copy link

@er-vin There is a notification in the activity list if files are not synced. Although it does not specify the reason.
Screenshot_2020-08-07_14-37-04
Client version: 2.6.5
OS: Windows 10
Server version: 19.0.1

Do you think there should be something more obvious, like a warning, maybe detailing the specific reason?

@er-vin
Copy link
Member

er-vin commented Aug 7, 2020

Might be a bit hard to be really specific, but at least the current message seems misleading since it's not symlinks or the ignore list in that case...

@sberegszaszi
Copy link

I also found several issues addressing the same broader question:
#2014
#1901
#1723
#464

@chillriver
Copy link
Author

Hi,
@chillriver Just asking to clarify, what do you mean by "folders called with double quotes". Do you mean, that they have double quotes in the name, like [This"folder"] for example?

Yes you are right.

@er-vin
Copy link
Member

er-vin commented Aug 11, 2020

I also found several issues addressing the same broader question:
#2014
#1901
#1723
#464

Thanks, good catch, I'll keep #464 only and close the other ones (including this one)

@er-vin er-vin closed this as completed Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code good first issue
Projects
None yet
Development

No branches or pull requests

4 participants