Rename "owncloudsync.log" files in sync directories

[LostInCompilation]

The Client (Windows 10, no virtual file system) is creating multiple hidden files in the sync directory, for example:
-".owncloudsync.log"
-".sync_c6217acc34d7.db"
-".sync_c6217acc34d7.db-shm"
-....

It looks like ".owncloudsync.log" is still an old leftover from the OwnCloud fork.
How about renaming them to ".nextcloudsync.log"?

[Jiaocz]

If you install serverside nextcloud, the default database prefix is still "oc_". LOL.

[LostInCompilation]

If you install serverside nextcloud, the default database prefix is "nc_". LOL.

What do you mean? I'm not talking about the server instance.

[Jiaocz]

If you install serverside nextcloud, the default database prefix is "nc_". LOL.

What do you mean? I'm not talking about the server instance.

Yes I know. I just mean that there are lots of things still named oc or owncloud like https://github.com/nextcloud/desktop/search?q=owncloud and https://github.com/nextcloud/desktop/search?q=oc

(I miswrite "oc_" to "nc_" sorry about that)

[LostInCompilation]

Yes I know. I just mean that there are lots of things still named oc or owncloud like https://github.com/nextcloud/desktop/search?q=owncloud and https://github.com/nextcloud/desktop/search?q=oc

Maybe someday this will get cleaned up :D
As long as it is pure backend, it's not a big deal. But having path names in the server code with "oc" in the name gave me some headaches once. Everything crashed because I assumed the path would have "nc" instead of "oc" as prefix...

[mgallien]

this file is needed by the internal mechanism that is monitoring files change and cannot be removed
I am not sure we really need to rename it and the priority for this would be very low in any case.
I prefer to close now rather than pretending we would do it.

[LostInCompilation]

I can understand that this is low priority, but not doing those little things will lead to more and more (filename) fragmentation and hard to find bugs. It's not the first time that I crashed a Nextcloud-Server because of this exact issue. 1000 files named nc_ and then there is one named oc_...
And I think your answer somehow confirmed this. If renaming this file is not an easy thing todo in the codebase, the problem with file-name fragmentation is already huge.

[joshtrichards]

Cleaned up some in #5271