Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove obsolete names #5271

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Feature/remove obsolete names #5271

merged 2 commits into from
Dec 15, 2022

Conversation

mgallien
Copy link
Collaborator

No description provided.

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien mgallien force-pushed the feature/removeObsoleteNames branch from 82416ca to 31b2146 Compare December 15, 2022 10:11
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

37.5% 37.5% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #5271 (31b2146) into master (051db4a) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5271   +/-   ##
=======================================
  Coverage   57.56%   57.56%           
=======================================
  Files         139      139           
  Lines       17576    17577    +1     
=======================================
+ Hits        10117    10119    +2     
+ Misses       7459     7458    -1     
Impacted Files Coverage Δ
src/libsync/logger.cpp 27.90% <0.00%> (ø)
src/csync/csync_exclude.cpp 89.54% <100.00%> (+0.02%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.50% <0.00%> (+0.22%) ⬆️

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5271-31b2146a1768b33defa06e0a0413261e96a959e9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit a21df5b into master Dec 15, 2022
@mgallien mgallien deleted the feature/removeObsoleteNames branch December 15, 2022 11:02
@mgallien mgallien added this to the 3.7.0 milestone Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants