Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the share dialog in QML #4777

Closed
claucambra opened this issue Jul 25, 2022 · 4 comments · Fixed by #4929
Closed

Rewrite the share dialog in QML #4777

claucambra opened this issue Jul 25, 2022 · 4 comments · Fixed by #4929
Assignees
Labels
enhancement enhancement of a already implemented feature/code feature: 👥 sharing Sharing dialog and functionalities.

Comments

@claucambra
Copy link
Collaborator

claucambra commented Jul 25, 2022

We have several open issues from the design/server/etc. side regarding desired changes to sharing, or the share dialog itself, open in this repo:

Two of these, particularly #3109 and #3845, are currently not doable due to the share dialog being a QWidget rather than a QML component. Other benefits of QMLification would include:

  • Better integration with the tray window
  • Reuse of existing components used in the tray window
  • Far easier visual customisation of components
  • Easier extension and addition of new components

The least painful solution would be to rewrite the share dialog in QML -- this would be a bigger task up front to reimplement everything but would pay dividends once this was done.

@mgallien @tobiasKaminsky @jancborchardt

@claucambra claucambra added the enhancement enhancement of a already implemented feature/code label Jul 25, 2022
@claucambra claucambra self-assigned this Jul 25, 2022
@claucambra claucambra added design feature: 👥 sharing Sharing dialog and functionalities. labels Jul 25, 2022
@tobiasKaminsky
Copy link
Member

This then would look more like tray window, but not any longer OS specific, right?
@jancborchardt I remember that we wanted to stay close to OR look&feel, is this still the case?

@claucambra
Copy link
Collaborator Author

claucambra commented Jul 26, 2022

@tobiasKaminsky not necessarily, we can make it look any way we want (including native)

@tobiasKaminsky
Copy link
Member

I added it to board.
Once it is picked up, we can discuss actual UX and track the subtasks.

@jancborchardt
Copy link
Member

@claucambra cool, sounds good. Native look is definitely nicer in the long run for that.

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Aug 18, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 🏗️ In progress in 🤖 🍏 Clients team Aug 18, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🏗️ In progress to 📄 To do (~10 entries) in 🤖 🍏 Clients team Sep 8, 2022
@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (~10 entries) to ☑️ Done in 🤖 🍏 Clients team Sep 14, 2022
@claucambra claucambra reopened this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code feature: 👥 sharing Sharing dialog and functionalities.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants