Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity url is wrong #4342

Closed
tobiasKaminsky opened this issue Mar 10, 2022 · 15 comments · Fixed by #4959
Closed

Activity url is wrong #4342

tobiasKaminsky opened this issue Mar 10, 2022 · 15 comments · Fixed by #4959
Assignees
Labels

Comments

@tobiasKaminsky
Copy link
Member

  • right click on a file -> activity
  • see https://$server/ocs/v2.php/apps/activity/api/v2/activity/filter?sort=asc&object_type=files&object_id=140430645098bde53c208&format=json
  • this gives 304
  • correct would be https://$server/ocs/v2.php/apps/activity/api/v2/activity/filter?sort=asc&object_type=files&object_id=14043064&format=json

--> only internal fileId without server id.

@claucambra
Copy link
Collaborator

Could you test with #4334 ?

@tobiasKaminsky
Copy link
Member Author

Now it shows something, but wrong content.
It shows something like "You successfully logged in using two-factor authentication (U2F device) " 363 days ago on an activity for a file.

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@github-actions github-actions bot added the stale label Apr 7, 2022
@tobiasKaminsky
Copy link
Member Author

Not stale…

@github-actions github-actions bot removed the stale label Apr 8, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This bug report did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you!

@github-actions github-actions bot added the stale label May 6, 2022
@github-actions
Copy link

This bug report is getting automatically closed due to no answer since the issue has been staled. Thank you!

@tobiasKaminsky
Copy link
Member Author

Tested with 3.5.0

@github-actions
Copy link

github-actions bot commented Jun 3, 2022

This bug report is getting automatically closed due to no answer since the issue has been staled. Thank you!

@tobiasKaminsky
Copy link
Member Author

@claucambra you startet working on this via #4777, but probably this is a bug in fetching activity info.
As a side note: we do not have activities for folders, so do not show there anything.

@camilasan camilasan self-assigned this Sep 5, 2022
@camilasan
Copy link
Member

@claucambra you startet working on this via #4777, but probably this is a bug in fetching activity info. As a side note: we do not have activities for folders, so do not show there anything.

the server (checking the file activity on the browser) is also giving a 304:
304-server

noactivity

The client seems to be sending the correct request with the file id.

Maybe we should ping @PVince81?

@camilasan
Copy link
Member

As a side note: we do not have activities for folders, so do not show there anything.

Where did you open the activities for folders?

@tobiasKaminsky
Copy link
Member Author

As a side note: we do not have activities for folders, so do not show there anything.

Where did you open the activities for folders?

Nowhere, but one activities and sharing is combined, activities could be shown, but this is not feasible, thus it was more an info / side note than an actual bug/task.

@camilasan
Copy link
Member

the server (checking the file activity on the browser) is also giving a 304

so turns out this is correct since activities are deleted after ~6 months (?). On files with activities we are correctly retrieving them:

fileactivities

This is a case to improve the UI, to display something when there are no activities.

I will work on it.

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Sep 8, 2022
@tobiasKaminsky tobiasKaminsky moved this from 🧭 Planning evaluation (dont pick) to 📄 To do (~10 entries) in 🤖 🍏 Clients team Sep 8, 2022
@tobiasKaminsky tobiasKaminsky moved this from 📄 To do (~10 entries) to 🏗️ In progress in 🤖 🍏 Clients team Sep 8, 2022
@camilasan
Copy link
Member

I will work on it.

@claucambra is already working on it in #4929.

@claucambra
Copy link
Collaborator

I will work on it.

@claucambra is already working on it in #4929.

Yeah, though as of now there is no placeholder for no activities. Won't be a big task to add it though :)

@claucambra claucambra self-assigned this Sep 20, 2022
@camilasan camilasan removed their assignment Sep 20, 2022
Repository owner moved this from 🏗️ In progress to ☑️ Done in 🤖 🍏 Clients team Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants