Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix file activity dialog #4334

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix file activity dialog #4334

merged 1 commit into from
Mar 16, 2022

Conversation

claucambra
Copy link
Collaborator

This PR fixes the file activity dialog, which shows up blank when clicking on certain file activities (e.g. deleted file activities).

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Mar 5, 2022
@claucambra claucambra mentioned this pull request Mar 10, 2022
Closed
@claucambra claucambra force-pushed the bugfix/fileactivitydialog branch from a480ebf to 99a9710 Compare March 10, 2022 12:14
@allexzander allexzander self-requested a review March 10, 2022 12:14
allexzander
allexzander approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment, minor. Tested the PR, seems to be working.

@claucambra claucambra force-pushed the bugfix/fileactivitydialog branch from 99a9710 to 8d0db0a Compare March 14, 2022 11:18
@claucambra claucambra requested a review from mgallien March 14, 2022 11:19
@mgallien
Copy link
Collaborator

can you have a look at existing automated tests for the model to increase coverage of the new lines of code ?
ActivityListModel should be easy
probably best to ignore the other as they looks mostly untested

@claucambra
Copy link
Collaborator Author

can you have a look at existing automated tests for the model to increase coverage of the new lines of code ? ActivityListModel should be easy probably best to ignore the other as they looks mostly untested

Added a couple of lines for the new code in the data function of the activitylistmodel

@claucambra
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the bugfix/fileactivitydialog branch from b1bbb6f to b5e6582 Compare March 16, 2022 07:34
@claucambra claucambra force-pushed the bugfix/fileactivitydialog branch from b5e6582 to 214552d Compare March 16, 2022 07:37
@claucambra
File activity dialog now works for all file actions activities (e.g. …
02f3a1a 
…deleted files)

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/fileactivitydialog branch from 214552d to 02f3a1a Compare March 16, 2022 07:38
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4334-214552da2c812e1b98f6a6bcae47d949381efb99-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@claucambra claucambra merged commit 454ae37 into master Mar 16, 2022
@claucambra claucambra deleted the bugfix/fileactivitydialog branch March 16, 2022 08:18
@mgallien mgallien added this to the 3.5.0 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @mgallien @nextcloud-desktop-bot @allexzander