Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-Scaled new logo in Windows 10 start menu tile #1405

Merged
merged 7 commits into from
Sep 6, 2019
Merged

Full-Scaled new logo in Windows 10 start menu tile #1405

merged 7 commits into from
Sep 6, 2019

Conversation

DominiqueFuchs
Copy link
Contributor

PR to finalize #22 in this repo. Discussion has already be done there.

These commits integrate the VisualElementsManifest.xml, corresponding logo files and CMakeLists.txt integrations.

Successfully tested on Windows (builds and results with client install output).

Feel free to comment. I tried to choose a logically good location for the VisualElementsManifest.xml in the src tree.

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…n appropiate install output folder

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…e to be set in client-building).

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
@DominiqueFuchs DominiqueFuchs added 3. to review enhancement enhancement of a already implemented feature/code labels Sep 6, 2019
@DominiqueFuchs DominiqueFuchs changed the title W10 start logo Full-Scaled new logo in Windows 10 start menu tile Sep 6, 2019
@DominiqueFuchs
Copy link
Contributor Author

I guess there may be some necessary some small addition in the client-building repo to install/organize the new assets. I'll look into this and - if necessary - propose changes there.

For this PR & issue I'm done FTM - @misch7 @camilasan @jancborchardt what's your thoughts on these changes?

@camilasan camilasan added this to the 2.6 Login flow v2 milestone Sep 6, 2019
@camilasan camilasan merged commit a70b7d5 into nextcloud:master Sep 6, 2019
@DominiqueFuchs DominiqueFuchs deleted the w10-start-logo branch September 6, 2019 15:34
Copy link
Member

@misch7 misch7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, works fine :-)

client-building was able to auto-adapt to these changes, so everything in "Program files" got deployed 😼

Btw.: I've seen your fork - Yesterday I updated client-building to reflect the current state used by our build servers ;)

PS: Oh not sure if this review to a merged PR finds it's way to you - so I just mention you @DominiqueFuchs ;)

@DominiqueFuchs
Copy link
Contributor Author

Awesome @misch7 , thanks!

Yeah, I noticed the cb chain went fine with the changes. 😄 I think I'll slowly get the grip for the "official" linux and windows build/packaging routines here, only my mac scripts feel still a bit "non-standard". Don't want to lead this PR off-topic, but if someone could give me a (very rough) insight in what buildchain the daily build server actually uses I'd be very happy. For Mac, in the admin folder on desktop a lot seems to be from the DMG days and client-building seems to be for linux & win only, so I'm a bit confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement of a already implemented feature/code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants