-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full-Scaled new logo in Windows 10 start menu tile #1405
Conversation
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…n appropiate install output folder Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
…e to be set in client-building). Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
I guess there may be some necessary some small addition in the client-building repo to install/organize the new assets. I'll look into this and - if necessary - propose changes there. For this PR & issue I'm done FTM - @misch7 @camilasan @jancborchardt what's your thoughts on these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works fine :-)
client-building was able to auto-adapt to these changes, so everything in "Program files" got deployed 😼
Btw.: I've seen your fork - Yesterday I updated client-building to reflect the current state used by our build servers ;)
PS: Oh not sure if this review to a merged PR finds it's way to you - so I just mention you @DominiqueFuchs ;)
Awesome @misch7 , thanks! Yeah, I noticed the cb chain went fine with the changes. 😄 I think I'll slowly get the grip for the "official" linux and windows build/packaging routines here, only my mac scripts feel still a bit "non-standard". Don't want to lead this PR off-topic, but if someone could give me a (very rough) insight in what buildchain the daily build server actually uses I'd be very happy. For Mac, in the admin folder on desktop a lot seems to be from the DMG days and client-building seems to be for linux & win only, so I'm a bit confused. |
PR to finalize #22 in this repo. Discussion has already be done there.
These commits integrate the VisualElementsManifest.xml, corresponding logo files and CMakeLists.txt integrations.
Successfully tested on Windows (builds and results with client install output).
Feel free to comment. I tried to choose a logically good location for the VisualElementsManifest.xml in the src tree.