-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile nextcoud gui as separate library #2834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
requested changes
Jan 18, 2021
FlexW
force-pushed
the
compile_nextcloud_as_lib
branch
from
January 31, 2021 20:11
d26200f
to
24f42fe
Compare
er-vin
reviewed
Feb 1, 2021
FlexW
force-pushed
the
compile_nextcloud_as_lib
branch
from
February 1, 2021 23:27
24f42fe
to
39a6c17
Compare
er-vin
approved these changes
Feb 2, 2021
/rebase |
Compiling nextcoud gui as a separate library. This is needed to more easily write tests. The whole nextcloud application can now be linked against the tests. Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
The test utils library collects all dependencies that are needed for tests and gets automatically linked with every test. Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
github-actions
bot
force-pushed
the
compile_nextcloud_as_lib
branch
from
February 2, 2021 13:35
39a6c17
to
d8493a9
Compare
AppImage file: Nextcloud-PR-2834-d8493a9b3b007d13d43e1822d6d9db8198810004-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com