Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile nextcoud gui as separate library #2834

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Conversation

FlexW
Copy link

@FlexW FlexW commented Jan 18, 2021

Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.

Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com

NEXTCLOUD.cmake Outdated Show resolved Hide resolved
src/gui/CMakeLists.txt Outdated Show resolved Hide resolved
@FlexW FlexW force-pushed the compile_nextcloud_as_lib branch from d26200f to 24f42fe Compare January 31, 2021 20:11
src/gui/CMakeLists.txt Outdated Show resolved Hide resolved
src/gui/CMakeLists.txt Outdated Show resolved Hide resolved
src/gui/CMakeLists.txt Outdated Show resolved Hide resolved
src/gui/CMakeLists.txt Outdated Show resolved Hide resolved
src/libsync/CMakeLists.txt Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@FlexW FlexW force-pushed the compile_nextcloud_as_lib branch from 24f42fe to 39a6c17 Compare February 1, 2021 23:27
@camilasan
Copy link
Member

/rebase

Felix Weilbach and others added 3 commits February 2, 2021 13:35
Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
The test utils library collects all dependencies that are needed for
tests and gets automatically linked with every test.

Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
@github-actions github-actions bot force-pushed the compile_nextcloud_as_lib branch from 39a6c17 to d8493a9 Compare February 2, 2021 13:35
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-2834-d8493a9b3b007d13d43e1822d6d9db8198810004-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@camilasan camilasan merged commit 0521dce into master Feb 2, 2021
@camilasan camilasan deleted the compile_nextcloud_as_lib branch February 2, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants