Avoid keeping Account alive via a shared ptr in ClientSideEncryption #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
er-vin
requested review from
ivan-cukic,
sbeyer,
camilasan,
allexzander,
FlexW and
DominiqueFuchs
FlexW
previously approved these changes
Jan 19, 2021
allexzander
approved these changes
Jan 26, 2021
|
/rebase |
added 2 commits
January 26, 2021 11:20
This account object was really only used during the initialization phase or for forgetting the sensitive data. So let's receive it as parameter there and pass it on from job to job as needed. Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
github-actions
bot
force-pushed
the
avoid_keeping_account_alive_from_subobject
branch
from
5bff1b0 to
d20fc1a
Compare
|
AppImage file: Nextcloud-PR-2840-d20fc1a6cefb9528e3aa919f6e13a6438241de30-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This account object was really only used during the initialization phase
or for forgetting the sensitive data. So let's receive it as parameter
there and pass it on from job to job as needed.
Signed-off-by: Kevin Ottens kevin.ottens@nextcloud.com