-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win tests compilation fix. #2901
Conversation
4038d6f
to
656e25f
Compare
You could expand on the commit message with what was the error. Just for later when looking at the git history it will be easy to understand what happened. |
If you change PRIVATE to PUBLIC on line 71 and 73 in |
This sounds reasonable. Any objections? Asking, since I am not CMAKE-expert. |
I agree with @FlexW this would be a better fix. We should slowly move to those more modern constructs. |
f644f35
to
7504d07
Compare
Alright then, @er-vin @FlexW @camilasan Let's approve + merge it. |
@allexzander I'm fine with the content of the commit now, still could you please address @camilasan comment about have a more descriptive commit message? She's right that this kind of things might come in handy. |
… of not being able to locate #include <sqlite3.h> in tests. Signed-off-by: allexzander <blackslayer4@gmail.com>
7504d07
to
3d266b9
Compare
AppImage file: Nextcloud-PR-2901-3d266b9246bb61c810cf81858b0c2b6768c988d7-x86_64.AppImage |
Signed-off-by: allexzander blackslayer4@gmail.com
Fix for Windows build error of not being able to locate #include <sqlite3.h> in tests.