VFS Windows: Fix download of large files

[FlexW]

Fixes #2952

Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com

[allexzander]

@FlexW Left my thoughts. Basically, the code is small enough to read, but, still, I'd try to simplify it if possible. We are risking of human-errors when working with arrays and offsets, so, the code must be as straightforward as possible in this case. I am going to go through everything one more time in the morning with my head fresh again :)

[er-vin]

Ah! Now we're talking, it's much smaller and straightforward now. Much closer to what I envisioned initially. Not too expensive either.

[er-vin]

Oops, clicked the wrong one :-)

Almost there anyway

[allexzander]

@FlexW Now, I like it too. I guess we just need those nitpicks from @er-vin addressed, and we are good to go! Thank you for being patient towards us :)

[allexzander]

@FlexW The only other thing I advise is to not be in hurry with squashing everything. These changes are small, so, it's ok to read them all multiple times as you keep pushing review comments fixes, but, for bigger PRs it would be easier if we could see the review comment fixes progression while we can also just browse all changes if needed. And then, we squash/rebase them right before the merge :)

[FlexW]

@FlexW The only other thing I advise is to not be in hurry with squashing everything. These changes are small, so, it's ok to read them all multiple times as you keep pushing review comments fixes, but, for bigger PRs it would be easier if we could see the review comment fixes progression while we can also just browse all changes if needed. And then, we squash/rebase them right before the merge :)

Okay, I keep that in mind for the next pr. I have now squashed the last nitpicks. Hope that is fine.

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-2958-523f1bcadd08e159278c920e5a1d728f44ea595e-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[allexzander]

@FlexW Looks good. Now, just need @er-vin to lift his request so we can proceed :)

[er-vin]

Woot! We got there now! Nice.