Use full-bleed Start Tile #2982
Conversation
|
I just realized this might create problems depending on how the manifest is created for OEMs, but it doesn't appear to be a template file. |
There was a problem hiding this comment.
Looks good! :) Just to be sure, this uses the file from https://github.com/nextcloud/promo/blob/master/nextcloud-icon.svg, right?
I don’t have Windows to test, so @FlexW @allexzander need to check :)
|
Btw @elsiehupp it’s super cool to see so many nice contributions from you! :) If you don’t mind I would add you to the Nextcloud Github organization – then you could directly work on branches of this main repo instead of a fork, which makes collaboration much easier. Also, we have a "Desktop team public" channel on our Nextcloud Talk instance for communication, I could add you there with a guest account via email if you like. Just send me an email to my first name at nextcloud dot com with the email you want to be added with. :) |
github-actions
bot
force-pushed
the
full-bleed-start-tile
branch
from
179ac98 to
a3c6865
Compare
|
Hi Jan—what’s the current status of this? Should it be merged, or not? (I’m just checking in because I don’t have any obvious next steps here myself.) |
Design-wise this looks good, just the code and actual working on Windows has to be checked. :) cc @mgallien @FlexW @camilasan @allexzander |
|
@tobiasKaminsky @mgallien @camilasan @allexzander could you check this out? @elsiehupp I assume this is still current and you only closed it because of lacking activity? Sorry! |
|
Hi @jancborchardt—Sorry for the lack of explanation! I closed this PR partially because of the lack of activity, yes, but also because Microsoft no longer uses Start Menu Tiles in Windows 11. There’s a new feature in Windows 11 called “widgets” which seem similar to Live Tiles, but it’s not clear how to create them. It could be nice to have a Nextcloud widget and a Nextcloud Live Tile that are roughly equivalent to each other, but that would probably be a lot of work, and it would have to wait on Microsoft releasing a widget development guide. If you want to use a full-bleed Start Tile in Windows 10 regardless, it would be worth testing to make sure still Windows 11 correctly uses a standard icon in the new Start Menu. I don’t currently have a working install of Windows 10 or Windows 11, so I can’t test this myself. |
|
I am going to have a look quickly |
|
@elsiehupp can you rebase and then we merge it |
|
/rebase |
mgallien
force-pushed
the
full-bleed-start-tile
branch
from
a3c6865 to
1e85564
Compare
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>
mgallien
force-pushed
the
full-bleed-start-tile
branch
from
1e85564 to
f929d1b
Compare
|
AppImage file: Nextcloud-PR-2982-f929d1bef047e989259426e59757ff659c0ec4e0-x86_64.AppImage |
|
/backport to stable-3.5 |
Closes #2954; see also #22 and #2903.
I have not actually tested this to see if it works, because I don't currently have a Windows setup, so could someone else build these changes and see if they at least have their intended effect? I'm working from this guide. I'm not sure if removing the explicit background color is a breaking change, but it seemed extraneous with a full-bleed icon.
As for the stylistic merits of using a full-bleed tile versus a masked icon, I'm not a Windows user, and I don't have the strongest opinions, but at the very least this change makes a pinned shortcut to the Nextcloud application visually distinct from a pinned shortcut to the Nextcloud folder. I'll do some digging to see how (or if) the Nextcloud folder icon is assigned, as described in #2903.