Check reading from journal was successful before remove placeholder #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
approved these changes
Mar 23, 2021
|
/rebase |
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
github-actions
bot
force-pushed
the
bugfix/check-db-read-successful-on-hydration-canceled
branch
from
e1ece7d to
d78774f
Compare
|
AppImage file: Nextcloud-PR-3028-d78774f29e9bb52efd057ecf7b97db20063fde94-x86_64.AppImage |
er-vin
reviewed
Mar 24, 2021
| const auto folderRelativePath = job->folderPath(); | ||
| SyncJournalFileRecord record; | ||
| if (!params().journal->getFileRecord(folderRelativePath, &record)) { |
There was a problem hiding this comment.
In fact you want to check that and the isValid flag on the record:
SyncJournalFileRecord record;
const auto ok = params().journal->getFileRecord(folderRelativePath, &record);
if (!ok || !record.isValid()) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com