Create std::wstrings out of const wchar_t* so a copy is created every time #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
force-pushed
the
bugfix/vfs-syncroot-reg-params-non-temp
branch
from
8a39f1d to
fa76e12
Compare
er-vin
reviewed
Apr 6, 2021
allexzander
force-pushed
the
bugfix/vfs-syncroot-reg-params-non-temp
branch
from
1218090 to
327bb31
Compare
… time. Signed-off-by: allexzander <blackslayer4@gmail.com>
allexzander
force-pushed
the
bugfix/vfs-syncroot-reg-params-non-temp
branch
from
4e4737e to
0a33e99
Compare
|
AppImage file: Nextcloud-PR-3061-4e4737e6d84c5e5da308d6568b421b9a49c743b4-x86_64.AppImage |
allexzander
changed the title
er-vin
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another way to fix const QString& passing by reference, issue.
As an alternative solution. This also works. I haven't really come up with an idea of why this is happening.
FYI, calling QString::toStdWString().data directly in the place of usage (filling in the info structure with these strings) works too. So, I am wondering, if I should do that instead?