use QFileInfo to check if path is absolute to avoid assert on windows #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bug/fixAssertEditIgnoredFiles
branch
from
cdf4dde to
790c2a8
Compare
allexzander
reviewed
Apr 6, 2021
src/gui/accountsettings.cpp
Outdated
| @@ -385,8 +385,10 @@ void AccountSettings::slotEditCurrentLocalIgnoredFiles() | |||
|
|
|||
| void AccountSettings::openIgnoredFilesDialog(const QString & absFolderPath) | |||
| { | |||
| Q_ASSERT(absFolderPath.startsWith('/')); | |||
| Q_ASSERT(absFolderPath.endsWith('/')); | |||
| #if !defined QT_NO_DEBUG | |||
There was a problem hiding this comment.
@mgallien As far as I remember, Q_ASSERT is empty in release build, so, this can be shortened to:
Q_ASSERT(QFileInfo(absFolderPath).isAbsolute())
There was a problem hiding this comment.
Thanks, much better now.
mgallien
force-pushed
the
bug/fixAssertEditIgnoredFiles
branch
from
790c2a8 to
4a63a8e
Compare
allexzander
approved these changes
Apr 7, 2021
er-vin
approved these changes
Apr 7, 2021
|
/rebase |
on windos absolute path does not have to start with / . Remove failing assert when editing ignored files list. Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
github-actions
bot
force-pushed
the
bug/fixAssertEditIgnoredFiles
branch
from
4a63a8e to
d6752c9
Compare
|
AppImage file: Nextcloud-PR-3068-d6752c96b1f357f2f92fe14b2d4f97946b0f69b3-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on windos absolute path does not have to start with / . Remove failing assert
when editing ignored files list.
Signed-off-by: Matthieu Gallien matthieu_gallien@yahoo.fr