Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix errors when calling CfRegisterSyncRoot by setting more fields #3187

Merged
merged 1 commit into from
Apr 26, 2021
Merged

fix errors when calling CfRegisterSyncRoot by setting more fields #3187

merged 1 commit into from
Apr 26, 2021

Conversation

mgallien
Copy link
Collaborator

sets a reasonable size of the StructSize members in the struct passed to
CfRegisterSyncRoot function

@mgallien mgallien mentioned this pull request Apr 23, 2021
Closed
@mgallien mgallien force-pushed the bugfix/fixCfRegisterSyncRoot branch 2 times, most recently from 6b45f6d to 1bd6480 Compare April 23, 2021 15:27
@mgallien
Copy link
Collaborator Author

/rebase

@mgallien
Copy link
Collaborator Author

Is this good to go ?

@mgallien
fix errors when calling CfRegisterSyncRoot by setting more fields
97d785f 
sets a reasonable size of the StructSize members in the struct passed to
CfRegisterSyncRoot function

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
@github-actions github-actions bot force-pushed the bugfix/fixCfRegisterSyncRoot branch from 1bd6480 to 97d785f Compare April 26, 2021 08:02
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3187-97d785f1bb49d77c2c78a00d73b1e5d9cfe5c361-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

er-vin
er-vin reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@er-vin er-vin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@allexzander
Copy link
Contributor

allexzander commented Apr 26, 2021 •
edited
Loading

@mgallien I'm positive about it.

@mgallien mgallien merged commit 74b5ca3 into master Apr 26, 2021
@mgallien mgallien deleted the bugfix/fixCfRegisterSyncRoot branch April 26, 2021 11:13
@mgallien
Copy link
Collaborator Author

/backport to stable-3.2

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 26, 2021
Merged
@mgallien mgallien mentioned this pull request Apr 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@er-vin er-vin er-vin left review comments

@allexzander allexzander allexzander approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@FlexW FlexW Awaiting requested review from FlexW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @nextcloud-desktop-bot @allexzander @er-vin