l10n: Replace apostrophe with double quotation #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
requested changes
May 10, 2021
src/gui/folderstatusmodel.cpp
Outdated
| } else { | ||
| //: Argument is a file name | ||
| allFilenames.append(tr("'%1'").arg(fileName)); | ||
| allFilenames.append("'%1'").arg(fileName); |
There was a problem hiding this comment.
Please replace the tr with QLatin1String instead of removing it.
There was a problem hiding this comment.
No need to use the special QLatin1String better use QStringLiteral.
QLatin1String may be useful but in very rare cases (wanting to use an override method highly optimized with it) and that is not the case there
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
FlexW
approved these changes
May 12, 2021
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Valdnet
requested review from
rakekniven,
er-vin,
allexzander and
camilasan
and removed request for
camilasan,
er-vin and
allexzander
rakekniven
approved these changes
May 20, 2021
|
AppImage file: Nextcloud-PR-3279-793c211232332621b8d3439813c2d5badd4efa91-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Valdnet 47037905+Valdnet@users.noreply.github.com