Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote folder prefix for renaming in a non-root local folder. #3311

Merged
merged 1 commit into from
May 17, 2021

Conversation

allexzander
Copy link
Contributor

Signed-off-by: allexzander blackslayer4@gmail.com

This fixes #3296 and #3270

@mgallien
Copy link
Collaborator

@allexzander can you try to add an automated test covering that case (rename with sync of folders behind the root folder) ?

@allexzander
Copy link
Contributor Author

@allexzander can you try to add an automated test covering that case (rename with sync of folders behind the root folder) ?

@mgallien I've checked unit tests. SyncMoveTest covers the changes I made.

@allexzander allexzander force-pushed the bugfix/rename-issue-for-custom-sync-root branch from ff6a63f to e684138 Compare May 17, 2021 09:44
@allexzander
Copy link
Contributor Author

@mgallien As discussed. Moved tests to separate branch for now to implement them later.

@allexzander
Copy link
Contributor Author

/rebase

Signed-off-by: allexzander <blackslayer4@gmail.com>
@github-actions github-actions bot force-pushed the bugfix/rename-issue-for-custom-sync-root branch from e684138 to 76be5dc Compare May 17, 2021 12:20
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3311-76be5dce73826d50edf9cc06e3f07902056df9cd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit cdadb00 into master May 17, 2021
@allexzander allexzander deleted the bugfix/rename-issue-for-custom-sync-root branch May 17, 2021 12:25
@biva
Copy link

biva commented May 27, 2021

Hello @alexandregv , do you think it will be integrated in the next release? Thanks!

@allexzander
Copy link
Contributor Author

@biva Thanks for reminding me. This hasn't been backported to 3.2.2. We'll see if we can still put it in. Worst case, it's going to 3.2.3.

@allexzander
Copy link
Contributor Author

/backport to stable-3.2

@biva
Copy link

biva commented Jun 11, 2021

Hi @allexzander I just wanted to know if it had been integrated in 3.2.2? Because I still have the issue with 3.2.2

@biva
Copy link

biva commented Jun 29, 2021

Hi @allexzander I just wanted to know if it had been integrated in 3.2.3? Because I still have the issue with 3.2.3 on Windows 10 (see #3240 (comment))

@biva
Copy link

biva commented Jul 6, 2021

Hi @allexzander sorry to push again, but were you able to have a look into it? The issue is still there for us

@biva
Copy link

biva commented Jul 13, 2021

Hello @allexzander I tested it with 3.2.4, still the same issue :( Could you please provide any update?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants