-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add remote folder prefix for renaming in a non-root local folder. #3311
Conversation
@allexzander can you try to add an automated test covering that case (rename with sync of folders behind the root folder) ? |
@mgallien I've checked unit tests. SyncMoveTest covers the changes I made. |
ff6a63f
to
e684138
Compare
@mgallien As discussed. Moved tests to separate branch for now to implement them later. |
/rebase |
Signed-off-by: allexzander <blackslayer4@gmail.com>
e684138
to
76be5dc
Compare
AppImage file: Nextcloud-PR-3311-76be5dce73826d50edf9cc06e3f07902056df9cd-x86_64.AppImage |
Hello @alexandregv , do you think it will be integrated in the next release? Thanks! |
@biva Thanks for reminding me. This hasn't been backported to 3.2.2. We'll see if we can still put it in. Worst case, it's going to 3.2.3. |
/backport to stable-3.2 |
Hi @allexzander I just wanted to know if it had been integrated in 3.2.2? Because I still have the issue with 3.2.2 |
Hi @allexzander I just wanted to know if it had been integrated in 3.2.3? Because I still have the issue with 3.2.3 on Windows 10 (see #3240 (comment)) |
Hi @allexzander sorry to push again, but were you able to have a look into it? The issue is still there for us |
Hello @allexzander I tested it with 3.2.4, still the same issue :( Could you please provide any update? Thanks! |
Signed-off-by: allexzander blackslayer4@gmail.com
This fixes #3296 and #3270