Check if first is not empty #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
reviewed
May 18, 2021
src/libsync/discovery.cpp
Outdated
| @@ -177,7 +177,7 @@ void ProcessDirectoryJob::process() | |||
| // For windows, the hidden state is also discovered within the vio | |||
| // local stat function. | |||
| // Recall file shall not be ignored (#4420) | |||
| bool isHidden = e.localEntry.isHidden || (f.first[0] == '.' && f.first != QLatin1String(".sys.admin#recall#")); | |||
| bool isHidden = e.localEntry.isHidden || (f.first.size() != 0 && f.first[0] == '.' && f.first != QLatin1String(".sys.admin#recall#")); | |||
There was a problem hiding this comment.
@FlexW Wouldn't f.isEmpty() do the same as f.first.size() != 0 but look shorter?
There was a problem hiding this comment.
@FlexW Also, I guess you forgot to add an assert and qcWarning. Just in case.
There was a problem hiding this comment.
@allexzander I'm not sure if we should add a warning. The entry that caused trouble came from e2e. Maybe it is expected that some names are empty?
FlexW
force-pushed
the
bugfix/check-if-first-is-empty
branch
from
d81e8f1 to
9bfeaaa
Compare
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/check-if-first-is-empty
branch
from
9bfeaaa to
39072b0
Compare
mgallien
approved these changes
Jun 22, 2021
allexzander
approved these changes
Jun 22, 2021
|
/rebase |
1 similar comment
|
/rebase |
If it's not checked that first is empty, crashes may happen. Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
github-actions
bot
force-pushed
the
bugfix/check-if-first-is-empty
branch
from
39072b0 to
c9715db
Compare
|
AppImage file: Nextcloud-PR-3333-c9715db7202ec4bc69dd3c673597aee74ecf2b07-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's not checked that first is empty, crashes may happen.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com