Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci/test appveyor #3345

Merged
merged 5 commits into from
Jul 21, 2021
Merged

Ci/test appveyor #3345

merged 5 commits into from
Jul 21, 2021

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien
Copy link
Collaborator Author

this is missing a proper blueprints repository within nextcloud org

@splitt3r
Copy link

https://github.com/owncloud/client/runs/2840197327 they are using GitHub Actions for Mac + Linux + Windows so everything (test binaries + logs etc.) is in one place. Which is pretty cool. Maybe an option here too? I don´t know how this will interfer with the nextcloud organisations CI minutes limit. I think Windows CI minutes are counted with factor 2 or sth. like that. Anyway great work here on getting Windows builds working 👍🏻

@mgallien
Copy link
Collaborator Author

mgallien commented Jul 12, 2021 •
edited
Loading

https://github.com/owncloud/client/runs/2840197327 they are using GitHub Actions for Mac + Linux + Windows so everything (test binaries + logs etc.) is in one place. Which is pretty cool. Maybe an option here too? I don´t know how this will interfer with the nextcloud organisations CI minutes limit. I think Windows CI minutes are counted with factor 2 or sth. like that. Anyway great work here on getting Windows builds working 👍🏻

sorry, I had missed your message
when trying to decide for a platform I saw that apparently the free tier of appveyor might be enough to kick start this and given most is specific to KDE's Craft and not so much to Appveyor

a switch later should be easy

another thing the desktop client of ownCloud is doing good is the use of SonarCloud that we are still missing

@mgallien mgallien force-pushed the ci/testAppveyor branch 3 times, most recently from c1d58f6 to 53b5ab2 Compare July 16, 2021 13:56
@mgallien mgallien marked this pull request as ready for review July 16, 2021 14:02
@mgallien mgallien force-pushed the ci/testAppveyor branch 4 times, most recently from bead09d to c0b3fe7 Compare July 21, 2021 08:20
@allexzander allexzander self-requested a review July 21, 2021 09:02
@mgallien
Copy link
Collaborator Author

/rebase

@mgallien
Copy link
Collaborator Author

/rebase

mgallien added 2 commits July 21, 2021 11:33
@mgallien
upgrade appveyor support to MSVC 2019
505121f 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
@mgallien
update CraftMaster git repository
9295bb4 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
mgallien and others added 3 commits July 21, 2021 11:33
@mgallien
build the nextcloud client and not something else
3601186 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
@mgallien
execute automated tests but do not fail if there are errors
bbcfe56 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@mgallien
only run the pipeline for master branch and pull requests
2bf757a 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3345-2bf757a6577a0f797d0d3e2d9c1fdc87f6eddf7c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 4553885 into master Jul 21, 2021
@mgallien mgallien deleted the ci/testAppveyor branch July 21, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlexW FlexW FlexW approved these changes

@allexzander allexzander allexzander approved these changes

@er-vin er-vin Awaiting requested review from er-vin

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgallien @splitt3r @nextcloud-desktop-bot @allexzander @FlexW