Set button on QMessageBox before changing the text #3346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allexzander
approved these changes
May 21, 2021
mgallien
approved these changes
May 26, 2021
| encryptButton->setText(AccountSettings::tr("Encrypt folder")); | ||
| e2eeWithVirtualFilesWarningMsgBox.exec(); |
There was a problem hiding this comment.
This is problematic because during that call things could be deleted and that would lead to a crash when the dialog is closed.
I did test by doing that:
- Create a folder in root via web browser
- Wait for the directory to be synced on Windows VFS
- Open Settings
- Try to Encrypt the folder
- See the new dialog appear
- Delete the not-yet encrypted folder via web browser
- Wait for the deletion to be synced
- Ask to encrypt the folder
- Expect a crash
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/e2ee-warning-vfs-dialog
branch
from
06e4709 to
470ab8a
Compare
|
/rebase |
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
github-actions
bot
force-pushed
the
bugfix/e2ee-warning-vfs-dialog
branch
from
470ab8a to
03610cb
Compare
|
AppImage file: Nextcloud-PR-3346-03610cb7063779eff506018c38cb49fe535da9de-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com