Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document --background #3380

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Document --background #3380

merged 1 commit into from
Jun 2, 2021

Conversation

uusijani
Copy link
Contributor

@uusijani uusijani commented May 28, 2021 •
edited
Loading

Fix #3374.

@FlexW
Copy link

FlexW commented May 31, 2021

/rebase

@FlexW
Copy link

FlexW commented May 31, 2021

Thanks @uusijani :)

mgallien
mgallien approved these changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the documentation update

@mgallien
Copy link
Collaborator

mgallien commented Jun 1, 2021

thanks for the documentation update

@uusijani Feel free to push more PR like this one. This is really appreciated

@mgallien
Copy link
Collaborator

mgallien commented Jun 1, 2021

/rebase

@mgallien
Copy link
Collaborator

mgallien commented Jun 1, 2021

/rebase

@FlexW
Copy link

FlexW commented Jun 2, 2021

/rebase

@FlexW
Copy link

FlexW commented Jun 2, 2021

@uusijani I'm not allowed to rebase your branch. Could you please rebase yourself and then merge? If you are not allowed to merge, please ping me.

@uusijani
Document --background
f4b1ba4 
Fix [nextcloud#3374](nextcloud#3374).

Signed-off-by: Jani Uusitalo <jani@mummila.net>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3380-f4b1ba45b81147d7a74e25c71d505e4e7918f861-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@uusijani
Copy link
Contributor Author

uusijani commented Jun 2, 2021

@FlexW I've now rebased and pushed the changes, hope this works for you. I don't see a way for me to merge this myself here, "Only those with write access to this repository can merge pull requests."

@FlexW FlexW merged commit 83498c3 into nextcloud:master Jun 2, 2021
@FlexW
Copy link

FlexW commented Jun 2, 2021

Perfect. Thanks :)

@uusijani uusijani deleted the patch-1 branch June 3, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlexW FlexW FlexW approved these changes

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No documentation for --background
5 participants
@uusijani @FlexW @mgallien @nextcloud-desktop-bot @allexzander