Bugfix/qml warnings #3388
Bugfix/qml warnings #3388
Conversation
src/gui/tray/UserLine.qml
Outdated
| width: 128 | ||
| text: name | ||
| elide: Text.ElideRight | ||
| color: "black" | ||
| font.pixelSize: Style.topLinePixelSize | ||
| font.bold: true | ||
| } | ||
| Row { | ||
| RowLayout { |
There was a problem hiding this comment.
do we really need a RowLayout inside another one ?
There was a problem hiding this comment.
I tried to go back to Row but I found it harder to keep Linux and Windows the same when comes to aligning the emoji with the message.
There was a problem hiding this comment.
my question was more about getting rid of the parent element and just using the parent RowLayout item
maybe it is just too hard to fix alignment issues in that case but I am wondering if that is possible (and that would reduce complexity)
There was a problem hiding this comment.
Please check my last commit. let me know if that is better or worst...
There was a problem hiding this comment.
they are looking fine for me
camilasan
force-pushed
the
bugfix/qml-warnings
branch
3 times, most recently
from
2508dd4 to
0c23fd3
Compare
camilasan
force-pushed
the
bugfix/qml-warnings
branch
from
0c23fd3 to
c9ecdc0
Compare
camilasan
force-pushed
the
bugfix/qml-warnings
branch
from
c9ecdc0 to
d7336d2
Compare
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/qml-warnings
branch
from
d7336d2 to
6bb2ac9
Compare
|
/rebase |
Signed-off-by: Camila <hello@camila.codes>
…out. Signed-off-by: Camila <hello@camila.codes>
…de Row. Signed-off-by: Camila <hello@camila.codes>
… in theme.h. Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
Signed-off-by: Camila <hello@camila.codes>
github-actions
bot
force-pushed
the
bugfix/qml-warnings
branch
from
6bb2ac9 to
7ddc4ca
Compare
|
AppImage file: Nextcloud-PR-3388-7ddc4ca170e3b5b363ba60b16a31e4c49981d2a1-x86_64.AppImage |
Partially fix #3070.
Most of these warnings were related to the User Status feature.
There are more PR's coming to fix some of these warning in other parts of the QML code.