Enable clazy in drone #3397
Merged
Enable clazy in drone #3397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
force-pushed
the
feature/enable-clazy-drone
branch
from
510a824 to
79170e4
Compare
|
In order to track our state and progress, we will use SonarCloud. That should really help with that |
3 tasks
mgallien
approved these changes
Jun 8, 2021
allexzander
approved these changes
Jun 8, 2021
|
/rebase |
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
FlexW
force-pushed
the
feature/enable-clazy-drone
branch
from
79170e4 to
3e3c124
Compare
|
AppImage file: Nextcloud-PR-3397-3e3c124af14fe3d3fc2fc0b1b797e644da1dbf8c-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com
Additionally to that I can setup a cron job on the server which then builds master every few hours and updates the number of warnings.
It might be possible to setup drone in a way that a pipeline which updates the number of warnings gets only executed when something is merged to master, but I haven't found out how to do this yet, and we said that we want to keep it quick and dirty;) Adding some conditional logic to the
count_compiler_warnings.pyscript which updates the number of warnings based on the active branch might be dangerous as we then would need to expose secrets to public pull requests.Of course we can use an different server for this.