Start macOS app bundle name with uppercase letter #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
force-pushed
the
bugfix/macos-set-bundle-name-correct
branch
from
b26e439 to
d49818a
Compare
|
can you test how it is behaving when we upgrade from a version without #3404 to a version with it ? |
FlexW
force-pushed
the
bugfix/macos-set-bundle-name-correct
branch
from
d49818a to
37548ed
Compare
|
@mgallien I can confirm that it works. |
camilasan
approved these changes
Jun 15, 2021
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/macos-set-bundle-name-correct
branch
from
37548ed to
8a7c905
Compare
|
/rebase |
It's a convention on macOS that app bundle names start with an uppercase letter. Also this aligns the app name with Windows and Linux. Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
github-actions
bot
force-pushed
the
bugfix/macos-set-bundle-name-correct
branch
from
8a7c905 to
7850551
Compare
|
AppImage file: Nextcloud-PR-3404-7850551cadd2769871590fcb771b16db13cab66c-x86_64.AppImage |
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a convention on macOS that app bundle names start with an uppercase
letter. This also aligns the app name with Windows and Linux.
Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com
Fixes #2898
Closes #2945