Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce https in flow2 for https connections #3542

Merged
merged 4 commits into from
Jul 21, 2021

Conversation

FlexW
Copy link

@FlexW FlexW commented Jul 13, 2021

Signed-off-by: Felix Weilbach felix.weilbach@nextcloud.com

@FlexW FlexW force-pushed the bugfix/enforce-https-with-flow2 branch 5 times, most recently from ba3fdd5 to 1d0304c Compare July 14, 2021 12:30
@FlexW FlexW force-pushed the bugfix/enforce-https-with-flow2 branch from 1d0304c to 0d6b1c1 Compare July 14, 2021 16:29
src/gui/creds/flow2auth.cpp Outdated Show resolved Hide resolved
src/gui/creds/flow2auth.cpp Outdated Show resolved Hide resolved
src/gui/wizard/webview.cpp Outdated Show resolved Hide resolved
src/gui/wizard/webview.cpp Outdated Show resolved Hide resolved
src/gui/wizard/webview.cpp Outdated Show resolved Hide resolved
@FlexW FlexW requested review from mgallien and allexzander July 19, 2021 09:13
@mgallien
Copy link
Collaborator

/rebase

@github-actions github-actions bot force-pushed the bugfix/enforce-https-with-flow2 branch from 97284ce to 6857829 Compare July 20, 2021 10:01
@FlexW
Copy link
Author

FlexW commented Jul 21, 2021

/rebase

@FlexW FlexW added this to the Desktop 3.3 milestone Jul 21, 2021
@github-actions github-actions bot force-pushed the bugfix/enforce-https-with-flow2 branch from 6857829 to 61a00f3 Compare July 21, 2021 13:13
@mgallien
Copy link
Collaborator

/rebase

Felix Weilbach added 4 commits July 21, 2021 17:15
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
@github-actions github-actions bot force-pushed the bugfix/enforce-https-with-flow2 branch from 61a00f3 to 3026516 Compare July 21, 2021 17:15
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3542-302651620b3b7612ef00fd91f27eacbfaf0f491b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit a8aa035 into master Jul 21, 2021
@mgallien mgallien deleted the bugfix/enforce-https-with-flow2 branch July 21, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants