Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove request to config for userVisibleURL. #3552

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Remove request to config for userVisibleURL. #3552

merged 1 commit into from
Jul 16, 2021

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Jul 15, 2021 •
edited
Loading

Signed-off-by: allexzander blackslayer4@gmail.com

To fix nextcloud/server#15688

_userVisibleUrl is always initialized in the void Account::setUrl(const QUrl &url)

mgallien
mgallien approved these changes Jul 15, 2021
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine but not sure I understand the background behind this change

@allexzander
Copy link
Contributor Author

seems fine but not sure I understand the background behind this change

@mgallien Android is using the already-known base URL (server URL) without requesting it via that /config endpoint. The property we are setting after receiving the response from the /config endpoint is already set to use the server URL at the start of the app. So, we don't really need that /config request, as, it would still return the URL we already have, and, will also result in a permissions error for some users. Hence, removing it, is a nice first step, as mentioned by Daniel in the Engineering.

@allexzander
Copy link
Contributor Author

/rebase

@allexzander
Remove request to config for userVisibleURL.
de627a9 
Signed-off-by: allexzander <blackslayer4@gmail.com>
@github-actions github-actions bot force-pushed the bugfix/remove-request-to-config-for-uservisibleurl branch from 9882118 to de627a9 Compare July 16, 2021 06:45
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3552-de627a9b7c869f70f00229b69f7aef76f51900df-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator

/rebase

@mgallien mgallien merged commit 545592c into master Jul 16, 2021
@mgallien mgallien deleted the bugfix/remove-request-to-config-for-uservisibleurl branch July 16, 2021 12:32
@kesselb kesselb mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlexW FlexW FlexW approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AH01630: client denied by server configuration: /var/www/nextcloud/config
4 participants
@allexzander @nextcloud-desktop-bot @mgallien @FlexW