do not block account menu: availability checking can be slow #3565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlexW
approved these changes
Jul 19, 2021
|
Fixes #3567 |
allexzander
approved these changes
Jul 20, 2021
|
@mgallien Nice. Just thought we could maybe just comment-out this code as we will be bringing it back later anyways. |
I prefer that we would do a revert like I did with the dynamic plugin loading code |
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/fixSlowMenuInSettings
branch
from
6853125 to
35949d2
Compare
|
/rebase |
github-actions
bot
force-pushed
the
bugfix/fixSlowMenuInSettings
branch
from
35949d2 to
e1867a5
Compare
|
/rebase |
ignore availability that can be very slow to check with CfApi virtual files plugin Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
github-actions
bot
force-pushed
the
bugfix/fixSlowMenuInSettings
branch
from
e1867a5 to
a8ef8bd
Compare
|
AppImage file: Nextcloud-PR-3565-a8ef8bdcb840cd4e474a71717e8c8392d7c23370-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore availability that can be very slow to check with CfApi virtual
files plugin
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com