Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print the real permissions string instead of its address #3569

Merged
merged 1 commit into from
Jul 21, 2021
Merged

print the real permissions string instead of its address #3569

merged 1 commit into from
Jul 21, 2021

Conversation

mgallien
Copy link
Collaborator

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

FlexW
FlexW approved these changes Jul 20, 2021
View reviewed changes
Copy link

@FlexW FlexW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@allexzander
Copy link
Contributor

Weird. QString is not a wchar_t, yet, the address is being logged instead of value. Well, if the fix works, I am fine with it.

@mgallien
Copy link
Collaborator Author

/rebase

@mgallien
print the real permissions string instead of its address
1fca075 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@github-actions github-actions bot force-pushed the bugfix/fixPermissionsLog branch from 9631c45 to 1fca075 Compare July 21, 2021 08:25
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-3569-1fca07546cdda7727d8732bb0b5ffc6ac0280af5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 58cf46f into master Jul 21, 2021
@mgallien mgallien deleted the bugfix/fixPermissionsLog branch July 21, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlexW FlexW FlexW approved these changes

@allexzander allexzander allexzander approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgallien @allexzander @nextcloud-desktop-bot @FlexW