Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for ActivityListModel #4135

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jan 4, 2022

PR also adds fixes to issues brought up by the tests :)

@claucambra claucambra self-assigned this Jan 4, 2022
@claucambra claucambra force-pushed the feature/testactivitylistmodel branch 8 times, most recently from d066195 to 52aeb28 Compare January 4, 2022 17:35
src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the feature/testactivitylistmodel branch from bfc294c to db19186 Compare January 5, 2022 11:11
@claucambra claucambra requested a review from mgallien January 5, 2022 11:28
src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
src/gui/tray/activitylistmodel.h Outdated Show resolved Hide resolved
src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
@claucambra claucambra requested a review from mgallien January 6, 2022 18:14
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot
a last comment

@claucambra claucambra requested a review from mgallien January 13, 2022 11:26
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really happy to see this !

src/gui/tray/activitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the feature/testactivitylistmodel branch 4 times, most recently from 67637db to 1d501d1 Compare January 14, 2022 17:00
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Outdated Show resolved Hide resolved
test/testactivitylistmodel.cpp Show resolved Hide resolved
test/testactivitylistmodel.cpp Show resolved Hide resolved
@claucambra claucambra requested a review from mgallien January 24, 2022 23:18
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@claucambra claucambra force-pushed the feature/testactivitylistmodel branch from 9b252dd to 119774a Compare January 26, 2022 22:23
@claucambra claucambra requested a review from mgallien January 26, 2022 22:24
@mgallien
Copy link
Collaborator

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/testactivitylistmodel branch from 119774a to e790a36 Compare January 31, 2022 15:01
@allexzander
Copy link
Contributor

@claucambra Please squash and merge.

@claucambra claucambra force-pushed the feature/testactivitylistmodel branch from e790a36 to d8c73ca Compare February 1, 2022 11:40
@claucambra
Copy link
Collaborator Author

/rebase

@nextcloud-command nextcloud-command force-pushed the feature/testactivitylistmodel branch from d8c73ca to 920feff Compare February 1, 2022 12:52
@claucambra
Copy link
Collaborator Author

/rebase

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@nextcloud-command nextcloud-command force-pushed the feature/testactivitylistmodel branch from 465260d to ce5494b Compare February 1, 2022 13:57
@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4135-ce5494b4ecf3ad094401d4796fdc75dfab7b1b12-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit fddd9dd into master Feb 1, 2022
@claucambra claucambra deleted the feature/testactivitylistmodel branch February 1, 2022 15:51
@mgallien mgallien added this to the 3.5.0 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants