Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Hirsute, add Jammy #4212

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Remove Hirsute, add Jammy #4212

merged 1 commit into from
Feb 1, 2022

Conversation

ivaradi
Copy link
Contributor

@ivaradi ivaradi commented Jan 27, 2022

Ubuntu Hirsute is obsolite, and Jammy is the next release.

mgallien
mgallien approved these changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
what is the status regarding current LTS ?

@ivaradi
Copy link
Contributor Author

ivaradi commented Jan 28, 2022

thanks what is the status regarding current LTS ?

What do you mean? The current Ubuntu LTS release is Focal (20.04), which is supported, but hardly, since it has Qt 5.12 only.

@ivaradi ivaradi force-pushed the hirsute_jammy branch 2 times, most recently from 5374d2f to 01c2cae Compare January 31, 2022 18:06
@mgallien
Copy link
Collaborator

mgallien commented Feb 1, 2022

thanks what is the status regarding current LTS ?

What do you mean? The current Ubuntu LTS release is Focal (20.04), which is supported, but hardly, since it has Qt 5.12 only.

sorry if my question was unclear
my question is about the current packages for Focal, are they good enough ? would you need help from us ?

@ivaradi
Copy link
Contributor Author

ivaradi commented Feb 1, 2022

sorry if my question was unclear my question is about the current packages for Focal, are they good enough ? would you need help from us ?

well, so far I could always update the patch so that the code compiles with Qt 5.12. I use the Focal version on my laptop and there seem to be no issues with that, nor have I received any bug reports specific to this version. So either very few people use it, or it is good enough.

@mgallien
Copy link
Collaborator

mgallien commented Feb 1, 2022

/rebase

@mgallien
Copy link
Collaborator

mgallien commented Feb 1, 2022 •
edited
Loading

sorry if my question was unclear my question is about the current packages for Focal, are they good enough ? would you need help from us ?

well, so far I could always update the patch so that the code compiles with Qt 5.12. I use the Focal version on my laptop and there seem to be no issues with that, nor have I received any bug reports specific to this version. So either very few people use it, or it is good enough.

Thanks for the status update and for your contributions !

@ivaradi @mgallien
Remove Hirsute, add Jammy
566a5e5 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4212-566a5e546576e817801b5e744d108f20b0917be5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@ivaradi ivaradi merged commit a66bed5 into nextcloud:master Feb 1, 2022
@ivaradi ivaradi deleted the hirsute_jammy branch February 1, 2022 15:15
@ivaradi
Copy link
Contributor Author

ivaradi commented Feb 1, 2022

/backport to stable-3.4

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 1, 2022
Merged
@mgallien mgallien added this to the 3.5.0 milestone Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

@nicolasfella nicolasfella Awaiting requested review from nicolasfella

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ivaradi @mgallien @nextcloud-desktop-bot @allexzander