Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add headers in cmake files to get them properly detected #4257

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Feb 7, 2022

qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien
Copy link
Collaborator Author

/rebase

qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4257-4371c0cbfed37fa319822e8433be61fd9ce4aa72-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 66e8ef3 into master Feb 11, 2022
@mgallien mgallien deleted the ci/addHeadersInCmake branch February 11, 2022 15:27
@mgallien mgallien added this to the 3.5.0 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants