Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback local move on server move failure #4303

Merged

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Feb 18, 2022

This should fix #4266

src/libsync/propagateremotemove.cpp Show resolved Hide resolved
test/testsyncengine.cpp Outdated Show resolved Hide resolved
test/testsyncengine.cpp Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from mgallien February 23, 2022 09:29
@allexzander allexzander force-pushed the feature/rollback-local-move-on-server-move-failure branch from 6f90fff to 24411ae Compare February 23, 2022 14:43
Signed-off-by: alex-z <blackslayer4@gmail.com>
@allexzander allexzander force-pushed the feature/rollback-local-move-on-server-move-failure branch from 24411ae to 3443de4 Compare February 23, 2022 14:53
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4303-3443de438800acfde8ee19f117fd019379fd71bf-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@allexzander allexzander merged commit 00d958e into master Feb 23, 2022
@allexzander allexzander deleted the feature/rollback-local-move-on-server-move-failure branch February 23, 2022 16:14
@allexzander
Copy link
Contributor Author

/backport to stable-3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement roll-back of move operation in case the upload to a new location on the server has failed
5 participants