properly ask Qt to create qml opengl surface with proper options #4340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
requested review from
camilasan,
tobiasKaminsky,
allexzander and
claucambra
claucambra
approved these changes
Mar 9, 2022
|
Tested with Nvidia and it works 👍 |
camilasan
approved these changes
Mar 9, 2022
allexzander
approved these changes
Mar 9, 2022
|
/rebase |
should prevent context losses error with some opengl drivers should prevent corruptions to occur with come opengl drivers Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
nextcloud-command
force-pushed
the
bugfix/preventOpenGLContextLosses
branch
from
700319d to
11e7ebd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
AppImage file: Nextcloud-PR-4340-11e7ebd5faed0504108bd009e1e6b74ba98f6121-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should prevent context losses error with some opengl drivers
should prevent corruptions to occur with come opengl drivers
Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com