Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build of appimage for branded clients #4414

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Apr 5, 2022

makes sure we install files in the proper prefix

makes sure the name of files is able to adapt to branded names

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@camilasan
Copy link
Member

/rebase

makes sure we install files in the proper prefix

makes sure the name of files is able to adapt to branded names

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the bugfix/fixBrandedAppimageBuilds branch from 5b24a65 to a5cb5d6 Compare April 6, 2022 09:19
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4414-a5cb5d60637b5d0e48e02ea5b8c76d1d56a936ea-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@camilasan camilasan merged commit 32a16ca into master Apr 6, 2022
@camilasan camilasan deleted the bugfix/fixBrandedAppimageBuilds branch April 6, 2022 10:49
@mgallien mgallien added this to the 3.5.0 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants