Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Realigned and resized thumbnails #4447

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Realigned and resized thumbnails #4447

merged 1 commit into from
Apr 27, 2022

Conversation

claucambra
Copy link
Collaborator

This PR reduces the size of the mime type-only icons while keeping the size of the image thumbnails larger. It also reduces the minimum height of activity entries to increase information density. The size of the sync status icon has also been adjusted and made slightly smaller.

Screenshot 2022-04-18 at 19 26 10
Screenshot 2022-04-18 at 19 26 32

@claucambra claucambra force-pushed the bugfix/thumbnail-changes branch from 561258b to 613ffef Compare April 18, 2022 17:30
@jancborchardt
Copy link
Member

Looks great @claucambra! :) The checkmarks from Tasks (or Deck?) look a bit big still, could we also reduce the size of these application icons just like the file type icons?

@claucambra claucambra force-pushed the bugfix/thumbnail-changes branch from 613ffef to b69891a Compare April 21, 2022 22:56
@claucambra
Copy link
Collaborator Author

Looks great @claucambra! :) The checkmarks from Tasks (or Deck?) look a bit big still, could we also reduce the size of these application icons just like the file type icons?

Yeah, here is a screenshot with the checkmarks slightly reduced in size:

Screenshot 2022-04-22 at 00 51 05

@claucambra claucambra requested a review from mgallien April 21, 2022 22:58
jancborchardt
jancborchardt approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great design-wise! :)

@mgallien
Copy link
Collaborator

/rebase

@claucambra @mgallien
Realigned and resized thumbnails
010f49a 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@mgallien mgallien force-pushed the bugfix/thumbnail-changes branch from b69891a to 010f49a Compare April 27, 2022 16:02
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4447-010f49a3923ae2870ec5c38e74f8d0b70583e5bf-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit 8ad08cd into master Apr 27, 2022
@mgallien mgallien deleted the bugfix/thumbnail-changes branch April 27, 2022 17:08
@mgallien mgallien added this to the 3.5.0 milestone Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@camilasan camilasan camilasan approved these changes

@allexzander allexzander Awaiting requested review from allexzander

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@claucambra @jancborchardt @mgallien @nextcloud-desktop-bot @camilasan