Fixed share link expiration box being ineditable and always attempting to set invalid date #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
approved these changes
May 16, 2022
… invalid date Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/share-link-expiry
branch
from
8092ecf to
31f3800
Compare
|
Kudos, SonarCloud Quality Gate passed! |
allexzander
approved these changes
May 16, 2022
|
/backport to stable-3.5 |
|
AppImage file: Nextcloud-PR-4543-31f3800d0d6dcae24d7f00edafe48b08c2deb68e-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where on servers with no set share link expire days, the date input box for the expiry of the link would have its maximum date set to the current date, which is considered invalid by the server. With a higher minimum than maximum date the box would also be uneditable, preventing the user from fixing the date.
This PR fixes this by only applying a maximum date if the server has a set number of days to expire (i.e. if this value is larger than 0),
Fixes #4068