Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a transparent background to the send reply button. #4578

Merged
merged 2 commits into from
May 25, 2022
Merged

Add a transparent background to the send reply button. #4578

merged 2 commits into from
May 25, 2022

Conversation

camilasan
Copy link
Member

Before:
before-gray-bkg

After:
after-no-gray-bkg

@camilasan camilasan mentioned this pull request May 19, 2022
Merged
claucambra
claucambra approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but small comment

src/gui/tray/TalkReplyTextField.qml Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the enh/talkreply-2 branch 2 times, most recently from 75055d1 to f9e6125 Compare May 24, 2022 12:32
Camila added 2 commits May 25, 2022 12:08
@mgallien
Add a transparent background to the send reply button.
f911c54 
Signed-off-by: Camila <hello@camila.codes>
@mgallien
Change color of text field to ncTextColor instead of ncSecondaryTextC…
6ff8265 
…olor.

Signed-off-by: Camila <hello@camila.codes>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4578-6ff82659ac220efb4aede30145b24e47a8507556-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented May 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mgallien mgallien merged commit b401bf0 into master May 25, 2022
@mgallien mgallien deleted the enh/talkreply-2 branch May 25, 2022 12:02
@mgallien
Copy link
Collaborator

@camila should we backport ?

@camilasan
Copy link
Member Author

/backport to stable-3.5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request May 25, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@camilasan @nextcloud-desktop-bot @mgallien @claucambra