Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent call dialogs from being presented when do not disturb is set as the user status #4611

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Prevent call dialogs from being presented when do not disturb is set as the user status #4611

merged 1 commit into from
Jun 10, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 6, 2022 •
edited
Loading

Closes #4607

@claucambra claucambra self-assigned this Jun 6, 2022
allexzander
allexzander approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@allexzander allexzander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Kindly, fix a code smell and it is good to go.

@claucambra
Copy link
Collaborator Author

Nice. Kindly, fix a code smell and it is good to go.

Thanks, fixed

@claucambra
Prevent call dialogs from being presented when do not disturb is set …
281e50f 
…as the user status

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 90a2f12 into master Jun 10, 2022
@claucambra claucambra deleted the bugfix/dnd-call branch June 10, 2022 10:05
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4611-281e50f4cd66e361ca5d56f46f056b4444dde81b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra mentioned this pull request Jun 15, 2022
Closed
8 tasks
@mgallien mgallien added this to the 3.6.0 milestone Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Do not show/ring call notification when user status is DND
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @allexzander