Redesign local folder information in the account-adding wizard

[claucambra]

Addresses point 3 of #4052

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

[codecov]

Codecov Report

Merging #4638 (d8d72e8) into master (bc7519a) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4638      +/-   ##
==========================================
- Coverage   56.56%   56.51%   -0.05%     
==========================================
  Files         138      138              
  Lines       17071    17071              
==========================================
- Hits         9656     9648       -8     
- Misses       7415     7423       +8     

Impacted Files	Coverage Δ
src/libsync/propagatedownload.cpp	64.00% <0.00%> (-1.19%)	⬇️

[nimishavijay]

Looks good! :) I'm also thinking if the path is more than 4 levels long we could show only the first and last folders and ellipsise in the middle?

[claucambra]

Looks good! :) I'm also thinking if the path is more than 4 levels long we could show only the first and last folders and ellipsise in the middle?

This is possible but difficult to do properly when it comes to a flexible layout, or window resizing, as QPushButton does not properly support things such as eliding on width changing :(

Would it be a better idea to display the folder path as a label, as we do with the remote location, and then have the button explicitly say "Change local folder" or something along those lines?

[nimishavijay]

Ah okay okay, then your solution makes sense :)
We could say "Choose another folder" or "Choose a different folder" or just "Choose folder" cc @jancborchardt on the wording here. If we are just using labels then can we ellipsise?

Also unrelated detail but we should middle align the 3 big icons (the avatar icon, the arrow, and the folder icon) if possible :)

[claucambra]

Ah okay okay, then your solution makes sense :) We could say "Choose another folder" or "Choose a different folder" or just "Choose folder" cc @jancborchardt on the wording here. If we are just using labels then can we ellipsise?

Labels can be elided, no problem!

Also unrelated detail but we should middle align the 3 big icons (the avatar icon, the arrow, and the folder icon) if possible :)

Sure, I will align them

[jancborchardt]

👍 on the middle-aligning of the avatar, arrow and folder icon. Username and "Local folder" text should be at the same height.

Also, the avatar is huge, can you reduce the size of it to match the folder icon? :)

And yep, we can do:

Local folder
Documents / Nextcloud (6 GB free space) [subline style, in grey]
Choose different folder [button]

[claucambra]

👍 on the middle-aligning of the avatar, arrow and folder icon. Username and "Local folder" text should be at the same height.

Also, the avatar is huge, can you reduce the size of it to match the folder icon? :)

And yep, we can do:

Local folder
Documents / Nextcloud (6 GB free space) [subline style, in grey]
Choose different folder [button]

@jancborchardt @nimishavijay

Turned out to not be as easy as expected, but here is a screenshot:

I moved the free space data to its own line as I felt in 99% of cases, the path text was too long to put the free space data alongside it, and it would elide the path too much to be useful

[nimishavijay]

Looks amazing now! Super nice :) 🚀

[jancborchardt]

Nice work! :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4638-d8d72e81bb6568fad7ee12d0435819923c541e5d-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.