Properly adapt the UserStatusSelectorModel to QML, eliminate hacks, make code more declarative #4650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
force-pushed
the
bugfix/userstatusselectormodel-refactor
branch
2 times, most recently
from
540be62 to
bafc6f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #4650 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 138 138
Lines 17068 17071 +3
=======================================
+ Hits 9646 9648 +2
- Misses 7422 7423 +1
|
camilasan
reviewed
Jun 21, 2022
claucambra
changed the title
mgallien
reviewed
Jun 24, 2022
claucambra
force-pushed
the
bugfix/userstatusselectormodel-refactor
branch
2 times, most recently
from
6af26cf to
cad2563
Compare
mgallien
approved these changes
Jun 26, 2022
camilasan
approved these changes
Jul 12, 2022
|
/backport to stable-3.5 |
…e more declarative Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
claucambra
force-pushed
the
bugfix/userstatusselectormodel-refactor
branch
from
cad2563 to
cf372b4
Compare
|
AppImage file: Nextcloud-PR-4650-cf372b43ac542268b528fe3149964815cdf669ad-x86_64.AppImage |
|
SonarCloud Quality Gate failed. |
|
The backport to stable-3.5 failed. Please do this backport manually. |
|
Best not to back port this, heavily dependent on the visual changes to the user status selector dialog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other changes include:
Signed-off-by: Claudio Cambra claudio.cambra@gmail.com