Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print sync direction in SyncFileStatusTracker::slotAboutToPropagate #4679

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

mgallien
Copy link
Collaborator

will avoid having to look up this information in other log parts

Signed-off-by: Matthieu Gallien matthieu.gallien@nextcloud.com

@mgallien mgallien marked this pull request as ready for review June 28, 2022 12:31
@camilasan camilasan force-pushed the bugfix/improveLogs branch from 4729a84 to 1404a18 Compare July 7, 2022 10:29
@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #4679 (8bbf6b6) into master (8b64cc8) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4679      +/-   ##
==========================================
- Coverage   56.41%   56.40%   -0.01%     
==========================================
  Files         138      138              
  Lines       17070    17069       -1     
==========================================
- Hits         9630     9628       -2     
- Misses       7440     7441       +1     
Impacted Files Coverage Δ
src/libsync/owncloudpropagator.cpp 86.00% <ø> (-0.03%) ⬇️
src/libsync/syncfilestatustracker.cpp 88.95% <100.00%> (ø)
src/libsync/propagatedownload.cpp 65.18% <0.00%> (-0.15%) ⬇️

@mgallien mgallien force-pushed the bugfix/improveLogs branch from 1404a18 to 0b15dc1 Compare July 19, 2022 14:33
mgallien added 2 commits July 20, 2022 14:17
will avoid having to look up this information in other log parts

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
no need to print a line each time we check for a name clash

always print a line when a clash is detected

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/improveLogs branch from 0b15dc1 to 8bbf6b6 Compare July 20, 2022 12:17
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4679-8bbf6b68d3d6385f29f748b8ce969ef5f78414fa-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra merged commit 2630b3c into master Jul 20, 2022
@claucambra claucambra deleted the bugfix/improveLogs branch July 20, 2022 13:13
@claucambra
Copy link
Collaborator

/backport to stable-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants