Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around issues with window positioning on Linux DEs, hardcode tray window to screen center when new account added #4685

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Work around issues with window positioning on Linux DEs, hardcode tray window to screen center when new account added #4685

merged 1 commit into from
Jul 4, 2022

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Jun 29, 2022 •
edited
Loading

This specifically addresses a situation where upon adding a new account through the account wizard, the tray window is opened where the cursor is

Addresses a point in #4052

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jun 29, 2022
@claucambra claucambra force-pushed the bugfix/workaround-window-positioning-linux branch from 45b153f to 251b442 Compare June 29, 2022 20:29
mgallien
mgallien reviewed Jun 30, 2022
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to split the clean up you did (think of removing Q_INVOKABLE from the behavior changes
that would allow easier bisect or revert in case that would be ever needed

@claucambra
Copy link
Collaborator Author

it would be nice to split the clean up you did (think of removing Q_INVOKABLE from the behavior changes
that would allow easier bisect or revert in case that would be ever needed

I will revert the clean-up changes and open a new PR with them

@claucambra claucambra force-pushed the bugfix/workaround-window-positioning-linux branch from 251b442 to 43db2a2 Compare June 30, 2022 13:33
@claucambra
Copy link
Collaborator Author

it would be nice to split the clean up you did (think of removing Q_INVOKABLE from the behavior changes
that would allow easier bisect or revert in case that would be ever needed

I will revert the clean-up changes and open a new PR with them

This is done now

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@claucambra claucambra force-pushed the bugfix/workaround-window-positioning-linux branch from 43db2a2 to 1ea1994 Compare July 4, 2022 11:14
@claucambra
Work around issues with window positioning on Linux DEs, hardcode tra…
22464f5 
…y window to screen center when new account added

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/workaround-window-positioning-linux branch from 1ea1994 to 22464f5 Compare July 4, 2022 12:11
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4685-22464f5005bedc351e6efdd516855c99bf59983a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra claucambra merged commit 0823729 into master Jul 4, 2022
@claucambra claucambra deleted the bugfix/workaround-window-positioning-linux branch July 4, 2022 22:13
@claucambra
Copy link
Collaborator Author

/backport to stable-3.5

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jul 12, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan camilasan approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@claucambra @nextcloud-desktop-bot @mgallien @camilasan